Skip to content

Add XOR example to Android JNI setup #12250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add XOR example to Android JNI setup #12250

wants to merge 1 commit into from
+8 −0

Conversation

georgehong
Copy link
Contributor

Summary

In preparation for adding the Android JNI, add the xor training model to the test prep script. Since the script will be adding the .ptd external weights to the test directory, also update the git ignore to account for this.

  • xor_only.pte -- includes model weights
  • xor.pte and xor.ptd includes XOR model with external weights, to be used together.

Test plan

Ensure that xor_only.pte, xor.pte, and xor.ptd are generated. Check CI is successful.

sh executorch_android/android_test_setup.sh

@georgehong
Add xor example to Android JNI setup
d55c131 
Summary:
In preparation for adding the Android JNI, add the xor training
model to the test prep script.

Test Plan:
Ensure that xor_only.pte, xor.pte, and xor.ptd are generated. Check
CI is successful.
@georgehong georgehong requested review from jathu and JacobSzwejbka July 7, 2025 21:21
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jul 7, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12250

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Cancelled Job, 2 Unrelated Failures

As of commit d55c131 with merge base 557b4de (image):

CANCELLED JOB - The following job was cancelled. Please retry:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 7, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 7, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jathu jathu Awaiting requested review from jathu

@JacobSzwejbka JacobSzwejbka Awaiting requested review from JacobSzwejbka

@kirklandsign kirklandsign Awaiting requested review from kirklandsign kirklandsign will be requested when the pull request is marked ready for review kirklandsign is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@georgehong @facebook-github-bot